add tests to invalid dynamic jumps#145
Open
alk0x1 wants to merge 11 commits intoparitytech:masterfrom
Open
Conversation
koute
reviewed
Jul 22, 2024
Co-authored-by: Koute <koute@users.noreply.github.com>
Co-authored-by: Koute <koute@users.noreply.github.com>
Co-authored-by: Koute <koute@users.noreply.github.com>
add early return in the failing test
inlined the code in the test and deleted the helper functions
jarkkojs
reviewed
Oct 25, 2024
| match result { | ||
| Ok(()) => panic!("Expected ExecutionError::Trap, but got Ok"), | ||
| Err(e) => assert!(matches!(e, ExecutionError::Trap(_)), "Expected ExecutionError::Trap, but got {:?}", e), | ||
| } |
Contributor
There was a problem hiding this comment.
More idiomatic Rust:
if let Err(e) == instance.call(state_args, CallArgs::new(&mut (), ext_main)) {
assert!(matches!(e, ExecutionError::Trap(_)), "Expected ExecutionError::Trap, but got {:?}", e);
} else {
panic!("Expected ExecutionError::Trap, but got Ok");
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for two cases of dynamic jumps that should return a
ExecutionError::Trap